Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remplace GLTF only when we save a improvement #111

Open
gdozot2 opened this issue Sep 18, 2024 · 1 comment · May be fixed by #113
Open

Remplace GLTF only when we save a improvement #111

gdozot2 opened this issue Sep 18, 2024 · 1 comment · May be fixed by #113
Assignees

Comments

@gdozot2
Copy link
Contributor

gdozot2 commented Sep 18, 2024

When we validate an image, we can improve the submitted result. In case of a position computation is requested, we overwrite the old GLTF and replace it by the new one. The problem is in case of we cancel the improvement. The GLTF is not reverted and is as possibly an bad position.

We should create and temp area to manage this case and replace the official only when we save the improvement

@gdozot2
Copy link
Contributor Author

gdozot2 commented Sep 23, 2024

After a second check, the main problem is not in case of cancel. But if we close the page without the cancel or if the computation during the cancel has a problem.

@gdozot2 gdozot2 self-assigned this Sep 24, 2024
@gdozot2 gdozot2 linked a pull request Sep 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant