Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report a fail status when skipping the CI on untrusted pull requests #169

Open
gilles-peskine-arm opened this issue Jun 24, 2024 · 0 comments
Labels
enhancement New feature or request size-s Estimated task size: small (~2d)

Comments

@gilles-peskine-arm
Copy link
Contributor

We do not run the main CI automatically on pull requests from external contributors who have not been approved individually. The way this works is that the CI script runs, detects that the pull request is untrusted and stops immediately. This results in a pull request that has two green ticks (from DCO and readthedocs) plus one pending status (the required check for pr-head) which will never complete without manual intervention. To a casual eye, this looks like a passing CI, but it's actually an incomplete CI. We should make it apparent that the CI hasn't run and manual action is needed.

The goal of this task is, when giving up on an untrusted CI, report a non-success status (pending or error), with a description indicating what is happening in a way that is comprehensible by newcomers.

@gilles-peskine-arm gilles-peskine-arm added enhancement New feature or request size-s Estimated task size: small (~2d) labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size-s Estimated task size: small (~2d)
Projects
Status: No status
Development

No branches or pull requests

1 participant