Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]:Creating new Compartment and Seats (Schema Change) #20

Open
HARISH-1222 opened this issue May 12, 2024 · 6 comments · May be fixed by #31
Open

[FEAT]:Creating new Compartment and Seats (Schema Change) #20

HARISH-1222 opened this issue May 12, 2024 · 6 comments · May be fixed by #31
Assignees

Comments

@HARISH-1222
Copy link

HARISH-1222 commented May 12, 2024

Hi there 👋. I read your code and it looks good. And based on your code most of the issues are super good

I have a new feature called Compartment seat allocation
instead of just giving the total_seats we can assign the compartment
train table is (one to many )related to compartment table

Here I gonna create a Seats table(default seat count: 10 seats (need your seg)) that is related to the compartment
with that, we can get the seat number like compartmentName+seatNo (because I have one feature idea once we done this feature)

1, The Admin needs to create a Compartment first with the default seat count that I mentioned earlier
2, After that we can assign multiple compartments to the train
3, Once the book the train that will come with compartmentName+seatNo

open to your suggestions 😊.

If you like, I will be happy to contribute....

@Mayank2808sharma
Copy link
Owner

@HARISH-1222
I have assigned the issue to you
Please go ahead.

@HARISH-1222
Copy link
Author

Hi @Mayank2808sharma, can you add level tags here ?, that would be nice, thank you. 😃

@HARISH-1222 HARISH-1222 changed the title [FEAT]:Add Compartment [FEAT]:Creating new Compartment and Seats (Schema Change) May 14, 2024
@HARISH-1222
Copy link
Author

Hi @Mayank2808sharma

Can you add level3 for this

I Updated the schema and implemented my login in all the routes that depend on booking and Train

and for the get train list route, It takes overtime to build.
because in source to destination first I need to get all the train and for each train, I need to get all the compartments and for each compartment, I need to get the seat based on the seat table

by the use of a seat table, we can assign different counts of seats for each compartment

Thank you for your understanding

if not that's also ok😊.

@chinmay3012
Copy link

Hi, Chinmay this side, I'd like to work on this issue.
I have experience with Node.js and Sequelize, and I can implement the new Compartment and Seats tables, update the models, and adjust the booking logic accordingly. I'll also add the necessary routes for creating compartments and seats. Here is a brief overview of my approach:

  1. Creating Compartment and Seats tables.
  2. Update models.
  3. Add routes for creating compartments and seats.
  4. Modify booking logic to include compartment and seat number.

Please assign this to me. Thanks!

@HARISH-1222
Copy link
Author

Hi @chinmay3012

I already completed the task and make PR.
@Mayank2808sharma is not available right now so i just hold it.

@chinmay3012
Copy link

Hi @HARISH-1222 thanks for the confirmation .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants