Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBD: Improve python wrap helper #59

Open
YairMarcowMavenomics opened this issue Nov 9, 2019 · 0 comments
Open

TBD: Improve python wrap helper #59

YairMarcowMavenomics opened this issue Nov 9, 2019 · 0 comments
Labels
TBD Issue that isn't yet fleshed out enough to work on, but should still be percolating

Comments

@YairMarcowMavenomics
Copy link
Contributor

We should generally review and iron out several issues with mavenworks.wrap .

Looking at Interactive Wrapper.ipynb etc,:

  • The demo generates weirdly named New Parts (not External Parts) per attached sceeenshot snippet.
  • The display is extremely clunky. We should discuss changes to the generation to:
    • Show argument by name (instead of arg0, arg1, etc.), hopefully possible via inspect.getfullargspec
    • ... with compact labels (perhaps aligning names in a (replaced or improved?) LabelPart to the left of each input, or it may be worth considering Layout container changes for that)
    • Consider accordion'ing, fixed hieights, etc. to better organize the screen (and e.g. bring kittens into view for the current demo)
    • We should brainstorm on possibilities on ways to better default input parts.

image

@YairMarcowMavenomics YairMarcowMavenomics added the TBD Issue that isn't yet fleshed out enough to work on, but should still be percolating label Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TBD Issue that isn't yet fleshed out enough to work on, but should still be percolating
Projects
None yet
Development

No branches or pull requests

1 participant