Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass fingerprint reason (int) for advanced functionality #93

Open
ndori opened this issue Apr 4, 2018 · 1 comment
Open

pass fingerprint reason (int) for advanced functionality #93

ndori opened this issue Apr 4, 2018 · 1 comment

Comments

@ndori
Copy link

ndori commented Apr 4, 2018

pass some raw data in case we want to use it, it might be a use case the library does not cover which will not cause it to be useless.

e.g. FINGERPRINT_ACQUIRED_GOOD... , FINGERPRINT_ERROR_UNABLE_TO_PROCESS, and so on.

In most case it won't be used but that's an important data that might be used

@Mauin
Copy link
Owner

Mauin commented Apr 5, 2018

I thought about this initially when designing this library and decided against this to make it as easy as possible to use the fingerprint APIs without having to touch too much of the internals and the states that you mention.

However especially with the new FingerprintDialog also providing states such as FINGERPRINT_ERROR_NO_FINGERPRINTS I can see the added benefit in this and I'll consider it for v3.

This also relates to #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants