CI is passing Windows job even though the tests are failing

[aryanjassal]

Describe the bug

Even though there are some failing tests on Windows, the CI doesn't actually fail the job, and considers the job as successful. This was only caught due to the CI also failing on a MacOS job, which was caught successfully.

To Reproduce

1. Run the Windows CI on a commit which is known to not work with Windows
2. Observe the log mentioning failed tests
3. Observe the CI marking the job as successful

Expected behavior

If the Windows tests fail, then the job should reflect that by failing.

Screenshots

N.A.

Platform

• Device: GitHub CI (js-rpc repo)
• OS: Windows
• Version: 0.6.3

Additional context

• Link to a pipeline which is meant to fail but is passing: https://github.com/MatrixAI/js-rpc/actions/runs/12193415711/job/34015714661

Notify maintainers

@brynblack

[linear]

ENG-488 CI is passing Windows job even though the tests are failing

[tegefaulkes]

Something like this should be a simple fix. In Linux you can set a flag in a script so the whole script fails if any part of it exits with a code. I assume the same can be applied to windows as well.