Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove toString override from ErrorPolykey #834

Open
tegefaulkes opened this issue Oct 22, 2024 · 1 comment
Open

Remove toString override from ErrorPolykey #834

tegefaulkes opened this issue Oct 22, 2024 · 1 comment
Labels
development Standard development

Comments

@tegefaulkes
Copy link
Contributor

Specification

Recently I added a toString override to the ErrorPolykey class as a way of extending it to include better details about the cause chain. After some discussion about it this needs to be removed infavor of an alternative method.

We need to create a utility what will structure errors as a more informative string to be used when we need to convert errors for use in logger messages. It needs to be aware of the type of error it receives and format it accordingly.

Additional context

Tasks

  1. remove the toString method from ErrorPolykey
  2. Create a utility that converts errors into formatted strings.
  3. Apply this utility wherever an error is being converted to a string with toString or the String constructor.
@tegefaulkes tegefaulkes added the development Standard development label Oct 22, 2024
Copy link

linear bot commented Oct 22, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development
Development

No branches or pull requests

1 participant