-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement timeoutMiddleware
and Remove metadata.authorization
for src/nodes/agent
Domain
#572
Comments
What is |
@CMCDragonkai you asked me to write up this issue, its regarding // Prevent overwriting the metadata type with `Omit<>`
type AgentRPCRequestParams<T extends Record<string, JSONValue> = ObjectEmpty> =
{
metadata?: {
[Key: string]: JSONValue;
} & Partial<{
authorization: string;
timeout: number;
}>;
} & Omit<T, 'metadata'>;
// Prevent overwriting the metadata type with `Omit<>`
type AgentRPCResponseResult<T extends Record<string, JSONValue> = ObjectEmpty> =
{
metadata?: {
[Key: string]: JSONValue;
} & Partial<{
authorization: string;
timeout: number;
}>;
} & Omit<T, 'metadata'>; And the fact that AgentService is a publicly accessible service, consequently it should not have an authorisation field. |
Is |
It is not a class, this issue has something to do with the |
Then rename the pr title. It's confusing. |
metadata.authorization
from src/nodes/agent
Domain, and Implement timeoutMiddleware
for src/nodes/agent
Domain
metadata.authorization
from src/nodes/agent
Domain, and Implement timeoutMiddleware
for src/nodes/agent
DomaintimeoutMiddleware
and remove metadata.authorization
for src/nodes/agent
timeoutMiddleware
and remove metadata.authorization
for src/nodes/agent
timeoutMiddleware
and remove metadata.authorization
for src/nodes/agent
Domain
timeoutMiddleware
and remove metadata.authorization
for src/nodes/agent
DomaintimeoutMiddleware
and Remove metadata.authorization
for src/nodes/agent
Domain
Issue is WIP
Specification
agentService
is a public service, so it should not haveauthorisation
, but in the current implementation, it does. Which is to be altered.agentService
currently does not usetimeoutMiddleware
, which it should.Additional context
js-rpc has a sister PR which addresses the same issues - MatrixAI/js-rpc#42
Tasks
AgentRPCRequestParams
andAgentRPCResponseResult
agentService
The text was updated successfully, but these errors were encountered: