Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More descriptive error messages for partial failure of API call #21

Open
amydevs opened this issue Mar 8, 2024 · 1 comment
Open

More descriptive error messages for partial failure of API call #21

amydevs opened this issue Mar 8, 2024 · 1 comment
Assignees
Labels
development Standard development r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices

Comments

@amydevs
Copy link
Contributor

amydevs commented Mar 8, 2024

Specification

The PKNS is going to be able to return partial failures regarding the RPC responses of particular nodes. We want to be able to provide more descriptive messages for these errors on the frontend.

image

The current error messages will need to be replaced depending on whether:

  • PKNS backend is able to connect to the Polykey nodes
  • RPC call timed out
  • The RPC method doesn't exist on the Polykey agent

Additional context

PKND issue: https://gitlab.com/MatrixAI/Engineering/Polykey/Polykey-Network-Status/-/issues/5

Tasks

  1. Make use of ErrorBoundary Suspense components for loading and error states
  2. Provide better messages on the frontend regarding specific in the responses from PKNS
@amydevs amydevs added the development Standard development label Mar 8, 2024
@amydevs
Copy link
Contributor Author

amydevs commented Mar 8, 2024

@faithveloro09 Roger told me that Polykey-Network-Dashboard deserves a redesign. He mainly talked in particular about the current error messages and how they are displayed in the current site. (screenshot in issue description).

@CMCDragonkai CMCDragonkai added the r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices
Development

No branches or pull requests

3 participants