You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our pkExec and pkSpawn process execution utilities were standardised in MatrixAI/Polykey#436, however, pkExpect was left unchanged due to the lack of shell option for nexpect.spawn. nexpect.spawn always spawns a child process with the default shell: false, however, for this to work with our docker integration tests we need to be able to set the shell option to true. Doing this would require either forking nexpect or switching to a different library.
Specification
Our
pkExec
andpkSpawn
process execution utilities were standardised in MatrixAI/Polykey#436, however,pkExpect
was left unchanged due to the lack ofshell
option fornexpect.spawn
.nexpect.spawn
always spawns a child process with the defaultshell: false
, however, for this to work with our docker integration tests we need to be able to set theshell
option totrue
. Doing this would require either forkingnexpect
or switching to a different library.Additional context
tests/utils/exec.ts
Polykey#432 - Original issue for process execution standardisation with more detailed specpkExec
andpkSpawn
(a similar procedure will be required to standardisepkExpect
)Tasks
shell
option when callingnexpect.spawn
or equivalentpkExpectWithoutShell
andpkExpectWithShell
variantsThe text was updated successfully, but these errors were encountered: