feat: added export option to secrets env #342 #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sooryasanand
commented
Dec 18, 2024
Comment on lines
+286
to
+290
| if (options.envExport) { | ||
| data += `export ${key}='${value}'\n`; | ||
| } else { | ||
| data += `${key}='${value}'\n`; | ||
| } |
There was a problem hiding this comment.
The if statement applies to Unix systems. On Windows, an equivalent check is unnecessary because the export keyword (or equivalent) isn’t needed. On Windows, child processes automatically inherit the parent process's environment variables, as documented on the official Microsoft website: Environment Variables.
There was a problem hiding this comment.
If that is the case, then instead of making this an option, we can probably make this another env format - something like --env-format unix-export. Or we can also rename this to be --env-format unix-local for non-export and --env-format unix-global for exported environment variables. Thoughts, @CMCDragonkai?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have introduced an export flag in options.ts to determine whether the export keyword should be prefixed to environment variables for shell usage. This is relevant for Unix-based systems, where export is required to make the variables available to child processes. On Windows, however, the export keyword or an equivalent is unnecessary because a child process automatically inherits the environment variables of its parent process. This behavior is documented on the official Microsoft website: Environment Variables.
Issues Fixed
secrets envcommand #342Tasks
Final checklist