Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows in secrets edit command #341

Open
aryanjassal opened this issue Dec 8, 2024 · 1 comment
Open

Add support for Windows in secrets edit command #341

aryanjassal opened this issue Dec 8, 2024 · 1 comment
Assignees
Labels
development Standard development

Comments

@aryanjassal
Copy link
Member

Specification

The secrets edit command has never had a Windows implementation. As such, this command is currently defunct for Windows. This is a major usability issue and this must be addressed before multiplatform tests can be added onto the CI.

Windows - VISUAL, EDITOR, get the .txt file association first, then default to notepad.exe and wait for it to finish. Windows never had a default terminal text editor.

If the defaults cannot be found, you need to error out, indicating that no default editor could be found, and users can instead choose to set VISUAL, EDITOR or pass in the "editor" program with --ed or something.

Furthermore it is important that the temporary being created can only be edited by the same user as the user who ran polykey secrets edit, otherwise it can be intercepted. The file should have a limited umask, like 700 equivalent for Windows.

Additional context

Tasks

  1. Implement secrets edit for Windows
  2. Make sure all the secrets edit tests are passing on Windows
@aryanjassal aryanjassal added the development Standard development label Dec 8, 2024
@aryanjassal aryanjassal self-assigned this Dec 8, 2024
Copy link

linear bot commented Dec 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development
Development

No branches or pull requests

1 participant