Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mime.define support. #86

Open
amirbilu opened this issue Nov 2, 2015 · 1 comment
Open

Adding mime.define support. #86

amirbilu opened this issue Nov 2, 2015 · 1 comment

Comments

@amirbilu
Copy link

amirbilu commented Nov 2, 2015

I was wondering whether it would be possible to support mime.define - https://github.com/broofa/node-mime#mimedefine -.

I can have it written and pull request.
Will you find it useful?

Many thanks.

@MathieuLoutre
Copy link
Owner

Interesting. I think it would be useful if you think it's useful. However, we did change the MIME lib a while ago to generate the full content type header because of encoding problems (which is much nicer) and we're using this library to do it: https://github.com/jshttp/mime-types
However it seems it doesn't have the ability to define custom types. If you're willing to tinker a bit or see a solution/other lib, I'm willing to take a PR (as long as we conserve the full content type header).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants