From 4348ff679fbf36471e94fc5d24f0d3fafc5a1476 Mon Sep 17 00:00:00 2001
From: Jan Teske <jteske@posteo.net>
Date: Tue, 21 Jan 2025 18:26:56 +0100
Subject: [PATCH] storage: don't require backward compat for parameters.proto

The protobuf types in this file are only used in the storage protocol
and never used across Mz versions.
---
 src/buf.yaml                           | 4 ++--
 src/storage-types/src/parameters.proto | 9 ++-------
 2 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/src/buf.yaml b/src/buf.yaml
index 5538ce5574e80..44c716c448924 100644
--- a/src/buf.yaml
+++ b/src/buf.yaml
@@ -65,8 +65,8 @@ breaking:
     - storage-types/src/connections/aws.proto
     # reason: currently does not require backward-compatibility
     - storage-types/src/connections/string_or_secret.proto
-    # reason: remove after the commit that introduced it gets merged
-    - storage-types/src/errors.proto
+    # reason: currently does not require backward-compatibility
+    - storage-types/src/parameters.proto
 lint:
   use:
     - DEFAULT
diff --git a/src/storage-types/src/parameters.proto b/src/storage-types/src/parameters.proto
index e789c6ac519b3..147cc638b3cea 100644
--- a/src/storage-types/src/parameters.proto
+++ b/src/storage-types/src/parameters.proto
@@ -7,6 +7,8 @@
 // the Business Source License, use of this software will be governed
 // by the Apache License, Version 2.0.
 
+// buf breaking: ignore (does currently not require backward-compatibility)
+
 syntax = "proto3";
 
 package mz_storage_types.parameters;
@@ -18,7 +20,6 @@ import "service/src/params.proto";
 import "tracing/src/params.proto";
 
 message ProtoStorageParameters {
-  reserved 1, 2, 3, 25, 12, 16, 26, 31, 39;
   uint64 keep_n_source_status_history_entries = 4;
   mz_rocksdb_types.config.ProtoRocksDbTuningParameters upsert_rocksdb_tuning_config = 5;
   bool finalize_shards = 6;
@@ -28,7 +29,6 @@ message ProtoStorageParameters {
   ProtoStorageMaxInflightBytesConfig storage_dataflow_max_inflight_bytes_config = 10;
   mz_service.params.ProtoGrpcClientParameters grpc_client = 11;
   uint64 shrink_upsert_unused_buffers_by_ratio = 13;
-  reserved 14, 15;
   mz_proto.ProtoDuration pg_source_snapshot_statement_timeout = 17;
   bool record_namespaced_errors = 18;
   uint64 keep_n_privatelink_status_history_entries = 19;
@@ -49,9 +49,6 @@ message ProtoStorageParameters {
   mz_proto.ProtoDuration replica_status_history_retention_window = 40;
 
   mz_dyncfg.ConfigUpdates dyncfg_updates = 30;
-
-  reserved 27;
-  reserved "enable_dependency_read_hold_asserts";
 }
 
 message ProtoPgSourceSnapshotConfig {
@@ -67,7 +64,6 @@ message ProtoMySqlSourceTimeouts {
 }
 
 message ProtoKafkaTimeouts {
-  reserved 6;
   bool keepalive = 1;
   mz_proto.ProtoDuration socket_timeout = 2;
   mz_proto.ProtoDuration transaction_timeout = 5;
@@ -87,7 +83,6 @@ message ProtoUpsertAutoSpillConfig {
 }
 
 message ProtoStorageMaxInflightBytesConfig {
-  reserved 2, 3, 5;
   optional uint64 max_in_flight_bytes_default = 1;
   bool disk_only = 4;
   optional double max_in_flight_bytes_cluster_size_fraction = 6;