You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the cross_price_elasticity.R file, in the line with comment "keep sales of sku as target and price of all other skus as other variables", the code following is not excluding the sku in the current loop but instead includes all the skus rather than all other skus.
input = df_casted %>% # keep sales of sku as target and price of all other skus as other variables
select(str_subset(names(df_casted), 'average_price'), target_variable)
If own elasticity is needed, then comment should be corrected to reflect the logic.
The text was updated successfully, but these errors were encountered:
Hey,
Thanks a lot for finding the time to open an issue here. I'm really happy that people still seem to stumble apon the repo I've created few years back. That said it's been a long time since I've last used R or worked on similar set of problems.
If there is an issue you'd like to fix I'm happy to take a pull request to fix it.
In the cross_price_elasticity.R file, in the line with comment "keep sales of sku as target and price of all other skus as other variables", the code following is not excluding the sku in the current loop but instead includes all the skus rather than all other skus.
input = df_casted %>% # keep sales of sku as target and price of all other skus as other variables
select(str_subset(names(df_casted), 'average_price'), target_variable)
If own elasticity is needed, then comment should be corrected to reflect the logic.
The text was updated successfully, but these errors were encountered: