Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containerSize() not defined #7

Open
ghxiao opened this issue Feb 11, 2014 · 5 comments
Open

containerSize() not defined #7

ghxiao opened this issue Feb 11, 2014 · 5 comments

Comments

@ghxiao
Copy link

ghxiao commented Feb 11, 2014

Hi, I am trying the latest version from the master branch. After opening index.html from browser, there is an exception "containerSize() not defined" whenever I drag the slider.

It seems that this bug was introduced in the commit f4b5c68
where sliderLength is changed to containerSize() but the function containerSize is not defined.
@lolodk
Copy link

lolodk commented Feb 14, 2014

I changed containerSize() to sliderLength and it works fine now.

@yoannmoinet
Copy link

Had the same issue,
this fix is working for me too.

@light-and-salt
Copy link

had the same issue, lolodk's fix worked for me +1

@ccorcos
Copy link

ccorcos commented Mar 18, 2014

same

@alecha
Copy link

alecha commented Apr 2, 2014

same, the fix solved the issue thanks

foobacca added a commit to aptivate/africawatermap that referenced this issue May 22, 2014
@foobacca
Add d3.slider files to source control
7a6f391 
with fix to slider js from MasterMaps/d3-slider#7
NullSoldier added a commit to BetterWorks/d3.slider that referenced this issue Aug 15, 2014
@NullSoldier
Fixed invalid variable name issue
0b12d21 
Bug indicated in MasterMaps#7
NullSoldier added a commit to BetterWorks/d3.slider that referenced this issue Aug 15, 2014
@NullSoldier
Fixed invalid variable name issue
ed7a2f8 
Bug indicated in MasterMaps#7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@yoannmoinet @light-and-salt @lolodk @ccorcos @ghxiao @alecha