Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when two range sliders are on the same page id #handle-one and #handle-two are not unique. #34

Open
martinfrances107 opened this issue Jun 3, 2015 · 1 comment

Comments

@martinfrances107
Copy link

I have found a semantic issue when I try and place two range sliders on the same page. In short some elements reuse what is supposed to be a unique id.

Looking at the demo page

http://benheb.github.io/d3.slider/

the range slider created by

d3.slider().value([10, 25 ])

here is an edited outline of the HTML

When there are two sliders on the page there will be 2 elements with unique id "handle-one" and two elements with id "handle-two"

The solution is to change the id attributes into class attributes - and then tighten up the select of element in the code where appropriate.

I really like this project and will try and find the time to work on the solution soon...but thought I should outline the issue.

@martinfrances107
Copy link
Author

This pull request fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant