Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the simplification algorithms properly parametric #8

Open
MasonProtter opened this issue Oct 2, 2018 · 0 comments
Open

Make the simplification algorithms properly parametric #8

MasonProtter opened this issue Oct 2, 2018 · 0 comments
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@MasonProtter
Copy link
Owner

Right now, the simplification algorithms found in src/Simplifications.jl will in theory work on any subtype of AbstractSymExpr but many of them are constructed so that they spit out a SymExpr which invalidates the purpose of making them parametric in the first place.

This isn't a high priority to fix because currently I only have one subtype of AbstractSymExpr (SymExpr) but it'd be good if I fixed this before I try implementing some other expression type that will get mysteriously simplified into a SymExpr

@MasonProtter MasonProtter added bug Something isn't working invalid This doesn't seem right labels Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant