First attempt to include the semantic highlight feature, introduced in specification 3.16.0. #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n specification 3.16.0.
|
Thanks! I guess the specification is probably a bit unfortunate, since the payload may be much larger than the ccls extension... |
|
I've been using this branch today and it looks like it works all right (at least, for starters… I didn't see any obvious errors or problems) @MaskRay is there any documentation of how to handle the missing |
2 tasks
MaskRay
force-pushed
the
master
branch
9 times, most recently
from
94ba2b3
to
c018bce
Compare
MaskRay
requested changes
Jun 6, 2021
| @@ -25,6 +25,47 @@ | |||
| namespace ccls { | |||
| using namespace llvm; | |||
|
|
|||
| std::vector<const char *> SEMANTIC_TOKENS = { | |||
| @@ -0,0 +1,257 @@ | |||
| // Copyright 2017-2020 ccls Authors | |||
There was a problem hiding this comment.
Omit year number // Copyright ccls Authors
|
|
||
| } | ||
|
|
||
| void MessageHandler::textDocument_semanticTokensFull( |
There was a problem hiding this comment.
This replicates too many lines in message_handler.cc. You can make the message_handler.cc implementation public and call that function.
MaskRay
force-pushed
the
master
branch
3 times, most recently
from
db890d4
to
cc13ced
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a crude attempt to include semantic highlights introduced in LSP spec 3.16.0:
https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_semanticTokens
It is mostly copied src/message_handler.cc#emitSemanticHighlight, with some tweaks. Feedback is welcome!