Files param doesn't have to be a dictionary type

[patrikwilliam]

robotframework-requests/src/RequestsLibrary/RequestsKeywords.py

Line 52 in 233ff7c

is_file_descriptor, list(files.values()) + [data]

It seems that a new change was introduced and now all the files used for POST have to be in the specific format.

However, this is not the case for all the scenarios. One can use Py requests to upload multiple files using list of tuples.

E. g.
multiple_files = [
('images', ('foo.png', open('foo.png', 'rb'), 'image/png')),
('images', ('bar.png', open('bar.png', 'rb'), 'image/png'))]

This no longer works and would be great to be fixed to be in align with Py requests library.

This causes the 'list' object has no attribute 'values' error. The workaround is to use the dictionary structure, but problem is if you need multiple files uploaded with same 'file' tag. Dictionary has to have unique key, having 4 times 'file' as the key is not possible.

[lucagiove]

when you talk about new change is in original requests library? could you provide more references to the changelog or documentation and the version you noticed this?

[patrikwilliam]

Hi @lucagiove thanks for a follow-up, it was broken by changes in commit 4de7ccd:
4de7ccd#diff-1a10b1ae09ff166af95b8df428f6c301eb3ab7357d207b8ded10eb09e93926de on Apr 8 which should have fixed the closing of files, though it brought this regression up.

Thanks @vanhanit for having the PR ready, it works fine if that matters, maybe @lucagiove can give you a code review unless there are other proposals to have this fixed?