-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error initializing triton - Error using xml_read Your MATLAB version is too old. You need version 7.1 or newer. #103
Comments
FYI Erik just encountered the same error after upgrading to 2023 |
I am also encountering this issue. Has anything been resolved as these comments were from several months ago? |
Dear All,
Did you pick up the change I committed to the main branch on June 10th?
The original author had a version check that used a regular expression that
was failing, here's my commit message:
Function relied on the Matlab version number being two single digits, e.g.
7.5. In Matlab 2024, version is 24.1, breaking the regexp. Updated to
parse multiple digit version number.
All my best,
Marie
…On Fri, Jul 12, 2024 at 2:28 PM atcook65 ***@***.***> wrote:
I am also encountering this issue. Has anything been resolved as these
comments were from several months ago?
—
Reply to this email directly, view it on GitHub
<#103 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQB76USZ6K7ULGEKWKRJP3ZMBC6VAVCNFSM6AAAAABC3DOCE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRWGM3TMOBVGU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Marie Roch
Professor of Computer Science, San Diego State University, GMCS-533 Tel: +1
619 594 5830
MAR Lab <https://roch.sdsu.edu/> and Marine Bioacoustics Research Collective
<http://acoustics.ucsd.edu/>
|
It looks like @fascimare had a fix for this in this commit (f56e573) but that hasn't been pulled into the main branch yet (#106) @marie-r is this - 7485ff3 - commit you are talking about? I picked that up when keeping my Triton updated but that commit only modifies the Could you make the same change to the main (I don't actually have the latest version of Matlab so can't test this...) |
I looked at commit (
<f56e57303139ce8d0c720
d092db7ee9e2b998cb1> f56e573, @fascimare) and I think that it will address
the new versions of Matlab but break the old ones:
%% Check Matlab Version
v = ver('MATLAB');
version = str2double(regexp(v.Version, '\d.\d','match','once'));
version = str2double(regexp(v.Version, '\d\d.\d','match','once'));
The problem was that we went from one digit to two, but older Matlab's still
have 1 digit. I went ahead and committed the following (commit
76deec4):
%% Check Matlab Version
v = ver('MATLAB');
version = str2double(regexp(v.Version, '\d+\.\d','match','once'));
which checks for one or more (\d+) digits and made sure that a period was
present (\.) as opposed to a any character (.).
I hadn't realized that there were multiple versions of xml_read. I updated
all of them and removed Remoras/Detector/xml_read.m as it is identical to
the one in the main triton directory.
The db code in Remora/Detector/db should be removed as it is old an out of
date. The Tethys remora should be used, or even better download the Tethys
client directly (https://tethys.sdsu.edu). If someone is using the detector
remora, I'd be happy to assist them with this, but I don't have time to
delete and test it right now.
All my best,
Marie
Marie Roch
Professor of Computer Science, San Diego State University, GMCS-533
<https://roch.sdsu.edu/> MAR Lab and <http://acoustics.ucsd.edu/> Marine
Bioacoustics Research Collaborative
From: sfregosi ***@***.***>
Sent: Monday, July 15, 2024 7:01 AM
To: MarineBioAcousticsRC/Triton ***@***.***>
Cc: marie-r ***@***.***>; Mention ***@***.***>
Subject: Re: [MarineBioAcousticsRC/Triton] Error initializing triton - Error
using xml_read Your MATLAB version is too old. You need version 7.1 or
newer. (Issue #103)
It looks like @fascimare <https://github.com/fascimare> had a fix for this
in this commit (
<f56e57303139ce8d0c720
d092db7ee9e2b998cb1> f56e573) but that hasn't been pulled into the main
branch yet (#106 <#106> )
@marie-r <https://github.com/marie-r> is this -
<7485ff33b7df76cc07548
7296de2086f565bf110> 7485ff3 - commit you are talking about? I picked that
up when keeping my Triton updated but that commit only modifies the xml_read
that is within the Tethys Remora so wouldn't help folks not running Tethys
(or with the primary xml_read higher on their path).
Could you make the same change to the main xml_read? It's line 95.
(I don't actually have the latest version of Matlab so can't test this...)
-
Reply to this email directly, view it on GitHub
<#103 (comment)
578937> , or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQB76XOZ7ZAPPV5B4E76NLZM
PIZXAVCNFSM6AAAAABC3DOCE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRYGU3TQ
OJTG4> .
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi triton team!
I recently updated to MATLAB 2023b and am receiving an error when attempting to open triton:
Error using xml_read
Your MATLAB version is too old. You need version 7.1 or newer.
This refers to xml_read.m lines 93-99 where the MATLAB version is checked. Perhaps things have changed in how MATLAB reports versions because the version that is returned by version = str2double(regexp(v.Version, '\d.\d','match','once'));
is 3.2, but the version is actually listed as 23.2.
When I try the same process on my version 2019a it returns version 9.7. I'm not sure if this is a MATLAB change, or just a bug in the 2023 versions, but it seems like a "simple" fix would be to change the regex search to include two digits (e.g. "23") not just one ("e.g. ignoring the "2" and jumping right to the "3").
I suggest changing line 95 to something like:
version = str2double(regexp(v.Version, '\d+','match','once')); to get the first digit before the decimal place (if we only care about it being higher than 7, and it's unlikely that someone with 7 and not 7.1 is going to use the software), or:
version = str2double(regexp(v.Version, '\d+.\d','match','once'));
If we want to capture the full number and the decimal.
Thanks!
Karli
The text was updated successfully, but these errors were encountered: