Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Multiple annotated pages #195

Open
stefv opened this issue Nov 17, 2022 · 1 comment
Open

[Request] Multiple annotated pages #195

stefv opened this issue Nov 17, 2022 · 1 comment

Comments

@stefv
Copy link

stefv commented Nov 17, 2022

Hello,

I like the way the annotate a page like the homepage with an annotation. But I'm working on a framework with a very light template website included inside. I imagine to have a default homepage and the developer using this framework overriding the default homepage by a new homepage.

For that, I'm planning to add an optional "weight" property on the annotations.

Do you think it can be a feature included in wicket-spring-boot in a future release if I make a pull request ?

@MarcGiffing
Copy link
Owner

Currently all Classes with the WicketPage are added to the WicketClassCandidatesHolder. The Exception is thrown in the WicketBootStandardWebApplication on line 99 and WicketBootSecuredWebApplication on line 110. I can imagine that we won't throw an Exception but order the classes by Spring Boots @order annotation or look at the @primary annotation to choose the right one. Of there are multiple HomePage classes annotated with @primary or with the highest precedence in the @order annotation an exception is thrown. Could you imagine to provide a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants