bump to polkadot v0.9.28 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
|
The tricky thing about this i guess is that upstream never delivered a 0.9.28, they went 0.9.26->0.9.32, so we need to mae sure to test this pretty thoroughly |
Garandor
reviewed
Jan 6, 2023
|
Is this PR the "correct" one or #5 by @zqhxuyuan ? They seem duplicated |
|
Yeah they are dupes, #5 is built from old branch structure so it would need to be rebased to be merged into I just opened new PR. and we will need to make 4.0.1 tag after this is merged |
Garandor
reviewed
Jan 13, 2023
Garandor
reviewed
Jan 13, 2023
Garandor
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Charles Ferrell [email protected]
Bump Nimbus to 0.9.28