Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessing GUI Page - Data completeness entry html validation incorrect #272

Open
glycoaddict opened this issue Mar 20, 2024 · 1 comment

Comments

@glycoaddict
Copy link

Describe the bug
In the preprocessing page, "Data completeness across samples cut-off (0.7 -> protein has to be detected in at least 70% of the samples)", the input box only allows either 0 or 1 integer values. However, we need float with a smaller step size.

Verified Fix
Original:

# ...\venv\alphapeptstatsenv\Lib\site-packages\alphastats\gui\pages\03_Preprocessing.py

data_completeness = st.number_input(
    f"Data completeness across samples cut-off \n(0.7 -> protein has to be detected in at least 70% of the samples)",
    value=0, min_value=0, max_value=1
)

Fixed version:

# ...\venv\alphapeptstatsenv\Lib\site-packages\alphastats\gui\pages\03_Preprocessing.py

data_completeness = st.number_input(
    f"Data completeness across samples cut-off \n(0.7 -> protein has to be detected in at least 70% of the samples)",
    value=0.0, min_value=0.0, max_value=1.0, step=0.01,
)

Note:

  1. must be float so use the 0.0 and 1.0 etc
  2. step size should be specified otherwise the html renders as integer of 1.
@JuliaS92
Copy link
Collaborator

This was fixed with step size 0.1, and the step size will be reduced in an upcoming version.

@mschwoer mschwoer mentioned this issue Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants