Open hdf files in read mode if read-only is set #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's check if this is a breaking change for hdf-based mmap @sophiamaedler |
jalew188
reviewed
Jul 17, 2024
GeorgWa
approved these changes
Jul 18, 2024
|
MB it is better to re-design this module in a more readable way. We can still use setattr, but it must be implemented by a well named method. |
definitely this module should be refactored, but this is beyond the scope of this change |
Lets keep the cur version like this then. |
jalew188
approved these changes
Aug 4, 2024
mschwoer
deleted the
180-race-condition-when-reading-speclib-from-two-instances
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #180