Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing Errors in Markup if any #57

Closed
naveen521kk opened this issue May 6, 2021 · 2 comments · Fixed by #58
Closed

Showing Errors in Markup if any #57

naveen521kk opened this issue May 6, 2021 · 2 comments · Fixed by #58
Assignees

Comments

@naveen521kk
Copy link
Member

We currently have a way to check whether the markup is valid or not, but that can be extended to having error messages that is understandable on where is the error is.
I have something working https://github.com/ManimCommunity/ManimPango/blob/cf13f34d4eec59e54143900e0a545d9c6ca0052f/manimpango/layout/utils.pyx which working on #48

@naveen521kk
Copy link
Member Author

@PhilippImhof what do you think about this? Can we break the API and release a major version(v0.3.0) or add an auxiliary function that manim will call if the MarkupUtils.validate fails?

@PhilippImhof
Copy link
Member

I think we can safely assume that ManimPango is almost exclusively used by Manim, so breaking the API should not be a big deal. And among 0.x versions, people generally know breaking changes are likely to happen. I would go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants