Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show rhythm codes #16

Closed
4 tasks
gregdyke opened this issue Sep 29, 2023 · 7 comments
Closed
4 tasks

Show rhythm codes #16

gregdyke opened this issue Sep 29, 2023 · 7 comments
Assignees
Labels

Comments

@gregdyke
Copy link
Collaborator

gregdyke commented Sep 29, 2023

Story

  • As a website visitor

  • I Want to be able to see only the rhythm codes ("parent codes to a set of related rhythm, e.g. the Blues rhythm code is parent to Struttin', Ballroomin', Piedmont triple")

  • So That I'm not overwhelmed by the number of rhythms

Acceptance Criteria

  1. Given a rhythm code exists
    • When the map is shown
    • Then the rhythm code is included
    • And it looks visually distinct from the rhythms (dot with surrounding circle?)
  2. Given a rhythm code exists with "child" rhythms
    • When the rhythm code is clicked/selected
    • Then a small pane is dropped down, listing the child rhythms
  3. Given a rhythm code pane is shown
    • When a rhythm is clicked
    • Then the modal for that rhythm is shown

Implementation Notes

Checklist:

  • I have defined the user story
  • I have defined some acceptance criteria
  • I have included any implementation notes
  • I have included all relevant links
@gregdyke gregdyke added the enhancement New feature or request label Sep 29, 2023
@gregdyke
Copy link
Collaborator Author

Screenshot 2023-09-29 at 18 02 06

@gregdyke
Copy link
Collaborator Author

gregdyke commented Sep 29, 2023

No longer doing this stretch goal as we are not showing the rhythms on the map for now.

Stretch goal: when a rhythm code is selected, highlight corresponding rhythms on the map

@gregdyke
Copy link
Collaborator Author

Concern: isolated rhythms would not belong to a rhythm code -> for now, no isolated rhythms
How many rhythm codes shown at 1 time -> just one code can be selected at any one time

@mferryRV
Copy link
Collaborator

mferryRV commented Oct 2, 2023

We need rhythm codes for DC hand dancing and Rumba Guaguanco in order to execute this effectively.

@gregdyke
Copy link
Collaborator Author

gregdyke commented Oct 3, 2023

For now, I have for you:

Rhythm code: Rumba (location cuba/havana)
Rhythms: (all same location - for now, distribute them in a grid around Havana and we will clarify with Deirdre)
Rumba Columbiana https://www.youtube.com/watch?v=W4aMl4HpKIQ
Rumba Guaguanco (already in db)
Rumba Yambu https://www.youtube.com/watch?v=Mux8ibZWbrg
Rumba Habanera https://www.youtube.com/watch?v=iLGuLEqtq7g

@gregdyke
Copy link
Collaborator Author

gregdyke commented Oct 5, 2023

As added in #22, we will stop showing rhythms as dots on the map and only show rhythm codes -> this could be done in this ticket, or separately

@christina-mifsud christina-mifsud self-assigned this Oct 6, 2023
@mferryRV
Copy link
Collaborator

mferryRV commented Oct 7, 2023

This is a prerequisite for #44

We need to modify the data structure we use to focus on lists of Rhythm Codes rather than Rhythms. Currently /apis/rhythms returns a list of rhythms. We either need an API endpoint for a list of rhythm codes and their child rhythms OR the front-end needs to group rhythms by rhythm code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants