Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling of Exceptions in Scopes #26

Closed
maxfischer2781 opened this issue Aug 25, 2019 · 3 comments
Closed

Handling of Exceptions in Scopes #26

maxfischer2781 opened this issue Aug 25, 2019 · 3 comments

Comments

@maxfischer2781
Copy link
Contributor

It seems that Scope does not properly catch-reraise exceptions in children. It still misses the facilities to detect errors in children and abort itself.
@eileen-kuehn
Copy link
Member

I would propose to write some unit tests showing this behaviour, or did you already do?

@maxfischer2781
Copy link
Contributor Author

No, I haven't done so yet. Good idea.

maxfischer2781 added a commit that referenced this issue Aug 28, 2019
@maxfischer2781
formulated test cases for exceptions in Scopes (#26)
d5efe56
@maxfischer2781 maxfischer2781 mentioned this issue Aug 28, 2019
Merged
5 tasks
@maxfischer2781
Copy link
Contributor Author

Fixed with #27. See also follow up improvements #29 and #30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxfischer2781 @eileen-kuehn