Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kosinski compression takes a long time if there's a long string of repeated bytes #6

Closed
DevsArchive opened this issue Aug 30, 2022 · 3 comments

Comments

@DevsArchive
Copy link

DevsArchive commented Aug 30, 2022

Let's say there's a long repeated string of 00s, which is what one of the files I have to compress to Kosinski has multiple of. The time it takes to compress it takes far too long to the point it causes Windows Explorer to stop responding.

@Clownacy
Copy link
Collaborator

Clownacy commented Aug 30, 2022

Probably related to this issue,?

Nah, KENSSharp uses some ported logic from my clownlzss project, while this uses flamewing's KENSC/mdcomp. KENSSharp is slow because the compression algorithm that it's using doesn't seem to agree with C#, while this sounds like it's down to a bug in the old version of KENSC that's being used.

If I remember right, I once considered updating KENSC, but, at the time, upstream KENSC had introduced a dependency on the Boost library or a cutting-edge version of C++ or something. Either way, I couldn't update KENSC.

@DevsArchive
Copy link
Author

DevsArchive commented Aug 30, 2022

Yeah, I realized that mistake and edited it out. I'm going to see if I can implement the updated version myself. Regarding Boost, it looks like it's only really in the big endian I/O stuff.

@DevsArchive
Copy link
Author

Got it to compile with the new mdcomp. And yeah, there's substantially better performance.

@DevsArchive DevsArchive closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants