Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid version in bowerfile #246

Open
Genkilabs opened this issue Sep 29, 2016 · 1 comment
Open

Invalid version in bowerfile #246

Genkilabs opened this issue Sep 29, 2016 · 1 comment

Comments

@Genkilabs
Copy link

The file bower.js and package.json on master shows version is 0.0.0 https://github.com/MailOnline/videojs-vast-vpaid/blob/master/bower.json

This is, I think, problematic for other services looking for the latest bower version.
ie. Projects like rails-assets will throw errors

Can we bump these in master to select the latest stable, as seen in video.js https://github.com/videojs/video.js/blob/master/package.json

I don't mind making a PR with it at 2.0.2 if you guys like.

@Genkilabs
Copy link
Author

Ah ha. The problem I am seeing is actually not the version in here but in VPAIDFLASHClients dep. for swfobject.

I made a ticket in there: MailOnline/VPAIDFLASHClient#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant