Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception on checking addresses #416

Open
Keith-CY opened this issue Jul 25, 2024 · 2 comments
Open

Exception on checking addresses #416

Keith-CY opened this issue Jul 25, 2024 · 2 comments
Assignees
@devchenyan
Labels
bug Something isn't working

Comments

@Keith-CY
Copy link
Member

Keith-CY commented Jul 25, 2024 •
edited
Loading

Describe the bug

352081456-feca6315-e0b4-4b31-bcb1-94249fc48e3b

Exception thrown in https://github.com/nervosnetwork/neuron/blob/master/packages/neuron-wallet/src/controllers/wallets.ts#L603

Expected behavior
undefined address should be clearly handled

  • Neuron Version: v0.116.2
@Keith-CY Keith-CY added the bug Something isn't working label Jul 25, 2024
@Keith-CY Keith-CY added this to Neuron Jul 25, 2024
@Danie0918 Danie0918 moved this to 🆕 New in Neuron Jul 25, 2024
@github-actions github-actions bot mentioned this issue Jul 26, 2024
Merged
@Danie0918 Danie0918 moved this from 🆕 New to 🏗 In Progress in Neuron Jul 29, 2024
@Danie0918 Danie0918 assigned devchenyan and unassigned Danie0918 Jul 29, 2024
@yanguoyu
Copy link

@devchenyan Could you change this log to This is not an unlock dao transaction ${unlockhash}. Maybe No unlock transaction use ${unlockHash} as input will let the user confuse

@devchenyan devchenyan mentioned this issue Jul 31, 2024
Merged
@devchenyan
Copy link

nervosnetwork/neuron#3216

@Danie0918 Danie0918 moved this from 🏗 In Progress to 🔎 Code Review in Neuron Jul 31, 2024
@Danie0918 Danie0918 moved this from 🔎 Code Review to 🚩Pre Release in Neuron Aug 1, 2024
@Danie0918 Danie0918 moved this from 🚩Pre Release to ⭐ Release List in Neuron Aug 1, 2024
@Danie0918 Danie0918 moved this from ⭐ Release List to 🚩Pre Release in Neuron Aug 1, 2024
@github-actions github-actions bot mentioned this issue Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devchenyan devchenyan

Labels
bug Something isn't working
Projects
Neuron
Status: 🚩Pre Release
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Keith-CY @devchenyan @yanguoyu @Danie0918