Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the KB, MB, and GB units in the chart to the more familiar K, M, and B. #381

Closed
Danie0918 opened this issue Jul 20, 2023 · 8 comments · Fixed by Magickbase/ckb-explorer-frontend#19
Assignees
Labels
enhancement New feature or request

Comments

@Danie0918
Copy link
Contributor

Confusion from users to be optimized

Currently we have KB, MB, GB units in our charts, which are not easy for users to understand, so we suggest replacing them with K, M, G.

@Danie0918 Danie0918 added the enhancement New feature or request label Jul 20, 2023
@Danie0918 Danie0918 moved this to 📫Hold On in CKB Explorer Jul 20, 2023
@Danie0918 Danie0918 moved this from 📫Hold On to 📌Planning in CKB Explorer Jul 20, 2023
@Danie0918 Danie0918 assigned Danie0918 and unassigned Sven-TBD Jul 24, 2023
@Danie0918 Danie0918 moved this from 📌Planning to 🆕 New in CKB Explorer Jul 24, 2023
@Danie0918 Danie0918 moved this from 🆕 New to 🏗 In Progress in CKB Explorer Jul 24, 2023
@Danie0918
Copy link
Contributor Author

Danie0918 commented Jul 24, 2023

There are 3 charts to adjust here, Balance Ranking, Total Deposit, and Daily Deposit.
[URL](https://explorer.nervos.org/charts)

[Balance Ranking]
image

[Nervos DAO]
image

@yixyxiu
Copy link

yixyxiu commented Jul 27, 2023

image

FYI: These 2 charts also need to be adjusted.

@PainterPuppets
Copy link

image

FYI: These 2 charts also need to be adjusted.

This seems to be already displayed as K/M/G, what should it be adjusted to?

@Danie0918
Copy link
Contributor Author

image
FYI: These 2 charts also need to be adjusted.

This seems to be already displayed as K/M/G, what should it be adjusted to?

Also included here are click-to-zoom charts, with the charts marked in red clicking to zoom in to see KB/MB/GB.

@PainterPuppets
Copy link

image
FYI: These 2 charts also need to be adjusted.

This seems to be already displayed as K/M/G, what should it be adjusted to?

Also included here are click-to-zoom charts, with the charts marked in red clicking to zoom in to see KB/MB/GB.

image

I don't seem to see KB/MG/GB when I zoom in either, maybe I'm not looking in the right place, can you help with a screenshot or link?

@Danie0918
Copy link
Contributor Author

I don't seem to see KB/MG/GB when I zoom in either, maybe I'm not looking in the right place, can you help with a screenshot or link?

It's already G here, any other adjustments needed? @yixyxiu

@yixyxiu
Copy link

yixyxiu commented Aug 1, 2023

I don't seem to see KB/MG/GB when I zoom in either, maybe I'm not looking in the right place, can you help with a screenshot or link?

It's already G here, any other adjustments needed? @yixyxiu

G -> B, GB->B。When the value reaches 1 billion, both Binance and CoinMarketCap (CMC) display it as "B." If we define 1G as 1 billion, displaying "B" as the unit is recommended. Additionally, for the adjustment of units, if previously 1MB = 1024 K = 1024 * 1024 CKByte, the adjusted unit should be 1M = 1000 K = 1000 * 1000 CKB。

image

image
https://www.binance.com/en/trade/BUSD_USDT?_from=markets&theme=dark&type=spot

@Danie0918

@PainterPuppets
Copy link

Got it. Already changed the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
4 participants