-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] mypy typings #569
Comments
Yeah, we would love to see typing support in asyncpg. |
Any update on whether asyncpg-stubs is planned to get merged into asyncpg? |
@1st1 #577 seems a bit too big to merge and review, but there is lots of stuff in that PR that can easily be merged and will help reduce the noise around the more critical/problematic changes. To give an example Does it make sense to start splitting off some of those contributions into separate PRs so that they can be merged and users can benefit from improved IDE suggestions as well as get #577 more manageable (and therefore more mergeable)? |
@elprans I know maintainers time is limited, but you just made a release and therefore seem the most active. I would like to dedicate time to getting type annotations for |
Happy to review if the typing-adding PR is split. It's nearly impossible to confidently review #577 as-is. |
Cool! I made a first PR to test the waters here: #1197 Let me know if there is anything you need from my side. |
Currently,
asyncpg
is untyped and has to be ignored as an import when usingmypy
. Because of this, I created anasyncpg-stubs
package generated fromstubgen
that I use in my own projects as a git dependency, but it would be great to have these in the main library (and verified by the developers). If this is something that is desired, I would be willing to create the initial PR.The text was updated successfully, but these errors were encountered: