Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickfix items replace grug-far window on open #340

Closed
kapral18 opened this issue Dec 30, 2024 · 4 comments · Fixed by #343, #344 or #345
Closed

Quickfix items replace grug-far window on open #340

kapral18 opened this issue Dec 30, 2024 · 4 comments · Fixed by #343, #344 or #345

Comments

@kapral18
Copy link

kapral18 commented Dec 30, 2024

What happens

When we save the result from grug-far window into quickfixlist and open the items from the list
they replace the grug far window thus inadvertantly creating a split of content.

What I expect

Grug far window should remain instact and quickfix item should open in the main window even if focus before was in grug-far

Config

Using default lazyvim grug-far config https://github.com/LazyVim/LazyVim/blob/d0c366e4d861b848bdc710696d5311dca2c6d540/lua/lazyvim/plugins/editor.lua#L131

@kapral18 kapral18 changed the title [BUG] quickfix items replace grug-far window on open Quickfix items replace grug-far window on open Dec 30, 2024
@MagicDuck
Copy link
Owner

Good idea! I've made it open the first quickfix item immediately in the "main" window! 😄
Let me know if you see any issue

@kapral18
Copy link
Author

kapral18 commented Jan 3, 2025

Sorry I didn't mean that it should auto-open, but rather when selected should open in main window

@MagicDuck
Copy link
Owner

hmm, I see. I was treating it uniformly with the case when there is no main window, in which case a main window needs to be created with some content. I think we can likely do without cfirst though if we already have a new window. I'll take a look later.

@MagicDuck
Copy link
Owner

done 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants