Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\Magenerds\GermanLaw\Block\AfterPrice::_getCmsLink breaks in a MultiWebsite Setup #42

Open
brosenberger opened this issue Jan 5, 2022 · 0 comments

Comments

@brosenberger
Copy link
Contributor

Setup:

  • Multiple website setup
  • The "same" shipping cms page for every website, resulting in that the url-key e.g. shipping is used multiple times within the system
  • select for each website the corresponding shipping page (a bit hard as only the title is shown in the dropdown)
  • click on the shipping link within the after price text

Result:

  • a 404 error page is shown

Expected:

  • the shipping page is shown

Additionals:

  • the link generated in the after price block has an added '|<>' within the url as the identifier of the page is stored within the configuration value
  • the \Magento\Cms\Model\Config\Source\Page::toOptionArray method uses the collections toOptionIdArray() which itself adds the idfield to the value-attribute for the option as the identifier (url-key of the page) is used multiple times in \Magento\Cms\Model\ResourceModel\AbstractCollection::toOptionIdArray
brosenberger added a commit to brosenberger/GermanLaw that referenced this issue Jan 5, 2022
see issue Magenerds#42, fix for wrong identifier if multiple pages exist with the same identifier (url-key) as the ID will be added to the configured value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant