Fixed #893 VenomShooter Ammo #958
Conversation
0x0ade
commented
Apr 15, 2012
0x0ade
commented
- Added check if the owner is player or not , if it's player use valid y position
|
I would merge the venom fix right now. But I don't know if we should accept more tiles now... |
|
I understand . Removing as soon as I removed my Joypad Implementation temporarily ... |
|
You should really try to use a branch for each feature or at least each Pull Request. |
|
Sorry , I can not remove the tile as for now ( IRC - My Joypad Implementation ... just got an " Milestone " : Bindings are working for Buttons , gonna add Axes ) . I may resend this pull request after finishing the joypad implementation if nobody has merged it to there . Usually can't you manually merge the fix from the diff ( thru your fork ) ? That would be even easier and faster , or must someone pull request it ? I think I am missing some limits ... EDIT : Removing everything - then just updating this pull request ... almost finished with joypad implementation , just precise shooting / mouse movement needs work ... |
|
No comment - Git just changed the IDs of some files and hasn't committed changes -.-'' Gonna retry to fix issue ASAP on current base of this repo =.= Such ... an ... messup ... I think next time I will really use branches for functions ... I have found parts of the Joypad in the diff ... hopefully the current upload ( forced an modified , redownloaded version of this repo ) will not fail |
|
WOOP It worked , proper commits committed , now mergeable |
|
@kylebrodie facepalm fuuuuuu But wait - won't pos.set(e.pos.x + xa * 4, e.pos.y + ya * 4); in Bullet still work ? |
|
Oh yes I see. It isn't necessary. You could change: bullet.pos.y = bullet.pos.y-19; -> bullet.pos.y -= 19; to make it a little more readable. |
|
Could ... won't do it because I will now kinda prepare myself for Ludum Dare . Even if : I would have to re-download the developer branch which takes ( by magic 150 kb/s where 1600 is my max ... ) 30 minutes . |
|
I could do it and then send you a pull request and it would be added into this pull request. |
