You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Refactor how CacheHandler? gets the AppManager?, Utils and ExpressionEvaluator?. Get this stuff from the event context instead of passing it in.
Changed 3 years ago by kurtwiersma
In talking with Peter we agreed that this is something we need to think about this more before we implemen. It might not make sense to do this refactoring.
I guess the simpliest thing to do is IoC wire in the utils, EE and properymanager after init and not wire in the appManager.
This biggest concern is making sure people can call cacheManager.clearCache() and not have to pass an event context object. The second conern is making sure that the cacheHandler can be united tested by reducing its hard coded dependencies.
comment:2 Changed 3 years ago by peterfarrell
Owner changed from kurtwiersma to peterfarrell
Status changed from new to assigned
comment:3 Changed 3 years ago by peterfarrell
Version changed from 1.8.0 - Framework to 1.9.0 - Framework
Milestone changed from Mach-II 1.8.0 alpha to Mach-II 1.9.0 alpha
For the sake of time, I'm re-targeting this for 1.9 as this is a very low priority at this time.
comment:4 Changed 2 years ago by peterfarrell
Milestone changed from Mach-II 1.9.0 alpha to Uncategorized
I think this is a purely academic change to the architecture. Re-targeting to uncategorized for later inclusion with the framework.
The text was updated successfully, but these errors were encountered:
(Moved from http://trac.mach-ii.com/machii/ticket/205)
Refactor how CacheHandler? gets the AppManager?, Utils and ExpressionEvaluator?. Get this stuff from the event context instead of passing it in.
Changed 3 years ago by kurtwiersma
In talking with Peter we agreed that this is something we need to think about this more before we implemen. It might not make sense to do this refactoring.
I guess the simpliest thing to do is IoC wire in the utils, EE and properymanager after init and not wire in the appManager.
This biggest concern is making sure people can call cacheManager.clearCache() and not have to pass an event context object. The second conern is making sure that the cacheHandler can be united tested by reducing its hard coded dependencies.
comment:2 Changed 3 years ago by peterfarrell
Owner changed from kurtwiersma to peterfarrell
Status changed from new to assigned
comment:3 Changed 3 years ago by peterfarrell
Version changed from 1.8.0 - Framework to 1.9.0 - Framework
Milestone changed from Mach-II 1.8.0 alpha to Mach-II 1.9.0 alpha
For the sake of time, I'm re-targeting this for 1.9 as this is a very low priority at this time.
comment:4 Changed 2 years ago by peterfarrell
Milestone changed from Mach-II 1.9.0 alpha to Uncategorized
I think this is a purely academic change to the architecture. Re-targeting to uncategorized for later inclusion with the framework.
The text was updated successfully, but these errors were encountered: