Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how CacheHandler gets the AppManager, Utils and ExpressionEvaluator #65

Open
mpwoodward opened this issue Mar 1, 2012 · 0 comments

Comments

@mpwoodward
Copy link

(Moved from http://trac.mach-ii.com/machii/ticket/205)

Refactor how CacheHandler? gets the AppManager?, Utils and ExpressionEvaluator?. Get this stuff from the event context instead of passing it in.

Changed 3 years ago by kurtwiersma

In talking with Peter we agreed that this is something we need to think about this more before we implemen. It might not make sense to do this refactoring.

I guess the simpliest thing to do is IoC wire in the utils, EE and properymanager after init and not wire in the appManager.

This biggest concern is making sure people can call cacheManager.clearCache() and not have to pass an event context object. The second conern is making sure that the cacheHandler can be united tested by reducing its hard coded dependencies.

comment:2 Changed 3 years ago by peterfarrell

Owner changed from kurtwiersma to peterfarrell
Status changed from new to assigned
comment:3 Changed 3 years ago by peterfarrell

Version changed from 1.8.0 - Framework to 1.9.0 - Framework
Milestone changed from Mach-II 1.8.0 alpha to Mach-II 1.9.0 alpha
For the sake of time, I'm re-targeting this for 1.9 as this is a very low priority at this time.

comment:4 Changed 2 years ago by peterfarrell

Milestone changed from Mach-II 1.9.0 alpha to Uncategorized
I think this is a purely academic change to the architecture. Re-targeting to uncategorized for later inclusion with the framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant