Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Nordpool connector #616

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Removing Nordpool connector #616

merged 1 commit into from
Oct 15, 2024

Conversation

MTrab
Copy link
Owner

@MTrab MTrab commented Oct 15, 2024

This is a breaking change as we are removing support for the following regions in this integration:

FI: Finland
EE: Estonia
LT: Lithuania
LV: Latvia
NO1: Oslo
NO3: Molde, Trondheim
NO4: Tromsø
NO5: Bergen
SE3: Stockholm
SE4: Malmö

This is done as part of future simplifications for this integration.

Essentially fixes #615

@MTrab MTrab self-assigned this Oct 15, 2024
@MTrab MTrab added bug Something isn't working minor Minor version bump breaking-change Introducing a breaking change labels Oct 15, 2024
@MTrab MTrab merged commit eda8cc9 into master Oct 15, 2024
3 checks passed
@MTrab MTrab deleted the Remove-Nordpool-Connector branch October 15, 2024 16:39
@enoch85
Copy link

enoch85 commented Oct 15, 2024

FYI, it works! Why remove it? This is SE4 in Sweden.

Screenshot_2024-10-15-23-51-45-76_c3a231c25ed346e59462e84656a70e50

@enoch85
Copy link

enoch85 commented Oct 15, 2024

Maybe some advice on how to bring it back: custom-components/nordpool@632ee5b

@MTrab
Copy link
Owner Author

MTrab commented Oct 16, 2024

I need to simplify this integration, as it has become too difficult to maintain.
This is just step one of the simplification, which unfortunately have removed alot of zones that are covered in the Nordpool integration

@enoch85
Copy link

enoch85 commented Oct 16, 2024

become too difficult to maintain.

Ask for help then! :) Sorry, but the decision made here seems to be based on 1 single issue, but apparently it still works for me for example.

I don't know anything about Python, but I can read code somewhat, and to me it seems like it's a few lines of code that needs changing. I.e the URL for the API, and changes to the some Country Codes.

For me personally, I use the entities from this plugin in a l o t of places in my HAOS. It would be a pain to change integration just because it's not maintained any more. For that reason I have asked around and are willing to pay the person who implements Nordpool back. If that's you, then fine. :)

@MTrab
Copy link
Owner Author

MTrab commented Oct 16, 2024

#618

Not fully ready for release, still needs some work, if I get the time (time is not a luxury in my life, unfortunately) it'll be released later today

@enoch85
Copy link

enoch85 commented Oct 16, 2024

Where can I donate?

@MTrab
Copy link
Owner Author

MTrab commented Oct 16, 2024

https://www.buymeacoffee.com/mtrab

@enoch85
Copy link

enoch85 commented Oct 16, 2024

Once merged and working there will be some coffee coming your way! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Introducing a breaking change bug Something isn't working minor Minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nordpool API returns 404
2 participants