Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Twitter ID as unique identifier #12

Open
krzkrzkrz opened this issue Sep 29, 2010 · 6 comments
Open

Store Twitter ID as unique identifier #12

krzkrzkrz opened this issue Sep 29, 2010 · 6 comments

Comments

@krzkrzkrz
Copy link

Wouldnt it be wise to store the twitter id and have that as the primary field instead of the twitter_handle? If a user decides to change his twitter name in twitter.com, then this gem will create a another user record on the db.

Second, how does the app keep track of users who change their twitter handle? At least with the twitter id, this will always be unique never changing...

@MSch
Copy link
Owner

MSch commented Sep 29, 2010

You are completely right, I did not think of that.

@krzkrzkrz
Copy link
Author

Glad to hear. Keep me updated

@krzkrzkrz
Copy link
Author

Hi MSch, any updates on this?

@amuino
Copy link

amuino commented Oct 7, 2010

I've got a partial fix for this submitted as a pull request: http://github.com/MSch/devise-twitter/pull/14

By reading this issue, I get that a couple more changes are needed so that users are looked up by their twitter_id and not twitter_handle.

I will work on that.

@amuino
Copy link

amuino commented Oct 7, 2010

Should be ready now.

The twitter_handle is updated (if needed) on connect or signup.

@mastermike14
Copy link

just to clarify, by contacting the twit api with a oauth token and secret and calling verify_credentials will return a user's twitter handle even if the correct one is not in the database. Oauth really is all about creating a secure environment to exchange information over an unsecure network, that was the original purpose anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants