Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem building MRPT-1.5 on windows [=> Old MRPT version for PL-SLAM] #957

Closed
DaddyWesker opened this issue Sep 13, 2019 · 15 comments
Closed

Comments

@DaddyWesker
Copy link

Hello, so i've tried to build mrpt for windows. CMake configured and generated project properly (i've added opencv path as it was strongly recommended), but whem i'm trying to build BUILD_ALL using visual studio i'm getting errors (see picture). What could be done to build it properly?

mrpt-problem

@jlblancoc
Copy link
Member

Hi,
Please, attach your CMakeCache.txt file, and also report what's the absolute path of your OpenCV build directory, as well as what version of OpenCV are you using.

@DaddyWesker
Copy link
Author

DaddyWesker commented Sep 14, 2019

Hello,

Here is full path to opencv installation D:\workspace\libs\Install\opencv

CMakeCache.txt

Opencv version... I've cloned opencv repo and contrib repo and built them. SO i guess it should be v4.

@jlblancoc
Copy link
Member

Ok, so it might be a compatibility problem with opencv 4... will check it.

@jlblancoc
Copy link
Member

I just tested it and mrpt at present builds cleanly against opencv4.

It looks like a misconfiguration of your MRPT's CMake build directory... Most opencv_* variables in cmakeCache are empty. Perhaps the OpenCV_DIR should point to somewhere else? Try setting OpenCV_DIR directly to the BUILD directory where you compiled opencv...

@DaddyWesker
Copy link
Author

Well, i've put exactly build location of opencv... Oh well, i'll try again maybe in the monday and will get back to you. Probably will try to rebuild opencv if this will not works

@jlblancoc
Copy link
Member

OpenCV_DIR:PATH=D:/workspace/libs/Install/opencv

Hmm... that is what you currently have, maybe that's the problem, it's probably safer to use the build directory instead.

@DaddyWesker
Copy link
Author

Alright, i've rebuilt opencv (downloaded 3.4.7 with contribs, built it from sources) and tried to rebuilt mrpt from scratch (deleted build dir and used cmake to generate code). And still...
mrpt-problem_2

CMakeCache.txt

@DaddyWesker
Copy link
Author

Current path for opencv is D:\workspace\libs\opencv\opencv\build

@jlblancoc
Copy link
Member

It's weird... today I rebuilt MRPT in Windows with opencv 3.4.5 and it builds cleanly. AppVeyor CI is also happy, so... I can't reproduce your problem (!)

What version of MRPT are you building? git master?

@DaddyWesker
Copy link
Author

DaddyWesker commented Sep 25, 2019

Not master. Actually, i'm trying to build this one https://github.com/pangfumin/gf-pl-slam and it says i need to build not master, but https://github.com/MRPT/mrpt/tree/0c3d605c3cbf5f2ffb8137089e43ebdae5a55de3

At least "this is the version they have tested".

@jlblancoc
Copy link
Member

Ah! So, bottom line is we must address rubengooj/pl-slam#30
:-)

@DaddyWesker
Copy link
Author

SO, i guess, nothing can be done until your issue for pl-slam is addressed?

@jlblancoc
Copy link
Member

Well, if you want to start giving a hand with this, build MRPT master on Windows, if that's the OS you will be using, and then try to build (GF-)-PL-SLAM against it, and let's see what needs to be updated in PL-SLAM.
There's a "how to port guide" here: https://docs.mrpt.org/reference/master/porting_mrpt2.html

@richard5635
Copy link

I faced this problem as well.
What I did was to comment out #include <opencv2/video/tracking_c.h> in
libs\img\include\mrpt\otherlibs\do_opencv_includes.h (it is at line 36 in my file)

I'm not sure if this is the right way to tackle this issue, but after that, I managed to build most of the projects. Now I am facing this problem here though..

@jlblancoc jlblancoc changed the title Problem building on windows Problem building MRPT-1.5 on windows [=> Old MRPT version for PL-SLAM] Oct 8, 2019
@jlblancoc
Copy link
Member

Closing, as this has been fixed upstream (though, the PR is still in the wait for merging):
rubengooj/pl-slam#40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants