Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make obs directory match case of other datasets for ISMIP6 ocean forcing #462

Open
xylar opened this issue Nov 22, 2022 · 0 comments
Open
Assignees

Comments

@xylar
Copy link
Collaborator

xylar commented Nov 22, 2022

#410 (comment)

@trhille:

Is it possible to make the 'Ocean_Forcing' part of this case-insensitive? It's a little awkward to have to have both an 'Ocean_Forcing' and an 'Ocean_forcing' directory when processing the obs and 2300 files, and it's not immediately apparent to the user why the ocean_thermal_obs case doesn't work when the ocean_thermal case does.

@hollyhan:

@trhille, this is a good point, and it would be ideal to have a case-insensitive directory for the ocean forcing files. The observational climatology file was originally only downloadable from the ISMIP6-2100 GHub endpoint, which is why I put the obs file in the same directory name Ocean_Forcing as that for the 2100 files. But the ISMIP6 committee has recently uploaded the obs data to the 2300 Ghub endpoint as well. I can see how to make the directory for the obs file case insensitive depending on which period_endyear is chosen in the config file in the following PRs I will create after merging this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants