Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export study calendar link does not work. #418

Closed
alireza-dhp opened this issue Apr 18, 2024 · 6 comments
Closed

Export study calendar link does not work. #418

alireza-dhp opened this issue Apr 18, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@alireza-dhp
Copy link
Member

The URL link for downloading calendar (.ics) file does not work properly.
http://localhost:8085/api/v1/calendar/studies/27/calendar.ics

image

@alireza-dhp alireza-dhp added the bug Something isn't working label Apr 18, 2024
@janoliver20 janoliver20 self-assigned this Dec 3, 2024
@janoliver20
Copy link

@andresgruber
Copy link
Contributor

We fixed which prevented the calendar from working.

But we do not suggest to keep the link to the calendar export because of two major reasons:

  1. The existing export is incomplete because, the calendar of a study might get complex especially if the study has multiple arms, relative observations cannot be simulated on a fixed calendar. Therefore we have built the "live" calendar within the study manager frontend which is directly connected to changes in the study configuration and allows filtering by group, observation, participant and simulating a specific entry date of a participant for a relative study.
  2. There is a possible information leak if we continue to use the existing link if one guesses a study id, b/c the link is not secured with authorization.

@alireza-dhp
Copy link
Member Author

Thank you for addressing the link issue.
After discussing with our internal team, we agree that removing the link from the study manager dashboard is acceptable for now.
In the future, we would like to request enhancements to the functionality, including implementing proper authorization checks to prevent any potential data leaks.

@janoliver20
Copy link

janoliver20 added a commit that referenced this issue Dec 12, 2024
The `exportStudyCalendar` function and related UI elements were removed from the codebase. This cleanup eliminates unused functionality, simplifying the component logic and reducing clutter in the studies module.
@janoliver20
Copy link

#567

janoliver20 added a commit that referenced this issue Dec 16, 2024
#418: Remove export calendar functionality from studies module
@andresgruber
Copy link
Contributor

The link to the calendar has been removed as well as the respective endpoint within the data gateway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants