Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building on PyPy #29

Open
apmorton opened this issue Jul 16, 2024 · 1 comment
Open

Building on PyPy #29

apmorton opened this issue Jul 16, 2024 · 1 comment

Comments

@apmorton
Copy link

conda-forge/aiocsv-feedstock#1

Py_UNREACHABLE is apparently not defined by pypy, and this causes the build to fail for pypy.

@MKuranowski
Copy link
Owner

Feel free to send patches for PyPy compatibility, however, do measure if the python parser implementation is also unbearably slow and the C extension is necessary.

Py_UNREACHABLE has been added in CPython 3.7, so if PyPy strives for full C api compatibility, it's an omission on their part.

I have considered in the past changing the code to only use the limited C API, but iirc necessary features were only added in 3.10, which conflicts with my desire to support all supported minor Python releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants