From 585ba4211a307feac140dee3ce647d3d1b0a5476 Mon Sep 17 00:00:00 2001 From: Vincent Jacques Date: Mon, 25 Sep 2023 16:24:22 +0000 Subject: [PATCH] Todo --- lincs/command_line_interface.py | 1 + lincs/liblincs/learning/mrsort-by-weights-profiles-breed.cpp | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/lincs/command_line_interface.py b/lincs/command_line_interface.py index e315d33a..e7e06657 100644 --- a/lincs/command_line_interface.py +++ b/lincs/command_line_interface.py @@ -237,6 +237,7 @@ def classification_problem( if allow_decreasing_criteria: command_line += ["--allow-decreasing-criteria"] print(f"# Reproduction command: {' '.join(str(c) for c in command_line)}", file=output_problem, flush=True) + # @todo(Feature, later) Add a line saying which version of lincs was used problem = lincs.generate_classification_problem( criteria_count, diff --git a/lincs/liblincs/learning/mrsort-by-weights-profiles-breed.cpp b/lincs/liblincs/learning/mrsort-by-weights-profiles-breed.cpp index d3145e18..39a0d4bd 100644 --- a/lincs/liblincs/learning/mrsort-by-weights-profiles-breed.cpp +++ b/lincs/liblincs/learning/mrsort-by-weights-profiles-breed.cpp @@ -112,6 +112,8 @@ Model LearnMrsortByWeightsProfilesBreed::perform() { } // Succeed? + // @todo(Feature, later) Let the user know which exit condition was reached + // (Maybe via a comment in the output file, like the "Reproduction command:" line) if (new_best_accuracy == learning_data.learning_alternatives_count || termination_strategy.terminate()) { for (auto observer : observers) { observer->before_return(); @@ -132,6 +134,8 @@ Model LearnMrsortByWeightsProfilesBreed::perform() { } // Fail + // @todo(Feature, later) Exit consistently with the other exit conditions: + // Don't fail, return the best model so far, and let the user know which exit condition was reached throw LearningFailureException(); }