Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Remove #type: ignore from SLM class #199

Open
ReinderVosDeWael opened this issue Jul 29, 2021 · 1 comment
Open

[REF] Remove #type: ignore from SLM class #199

ReinderVosDeWael opened this issue Jul 29, 2021 · 1 comment
Labels
Python On the Python implementation

Comments

@ReinderVosDeWael
Copy link
Contributor

ReinderVosDeWael commented Jul 29, 2021 •
edited
Loading

Currently, mypy crashes on SLM.py due to an import inside a class. This issue is tracked at mypy/issuse/10521.

Once mypy resolves it issue, this issue can be solved by simply removing the following: https://github.com/MICA-MNI/BrainStat/blob/master/brainstat/stats/SLM.py#L1
@ReinderVosDeWael ReinderVosDeWael added low priority Low priority issues Python On the Python implementation on hold Issues that rely on fixes to external software labels Jul 29, 2021
@ReinderVosDeWael ReinderVosDeWael mentioned this issue Apr 11, 2022
Closed
@zihuaihuai
Copy link
Collaborator

mypy is temporary removed now, will mark this issue as add mypy back

@zihuaihuai zihuaihuai removed low priority Low priority issues on hold Issues that rely on fixes to external software labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Python On the Python implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REF] Remove "type: ignore" form SLM.py MICA-MNI/BrainStat
2 participants
@ReinderVosDeWael @zihuaihuai