Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With grid enabled closing a contour can instead create a subdivision in some cases. #149

Open
MatthewBlanchard opened this issue Jul 15, 2021 · 2 comments
Open

With grid enabled closing a contour can instead create a subdivision in some cases. #149

MatthewBlanchard opened this issue Jul 15, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@MatthewBlanchard
Copy link
Contributor

Not sure what's causing this exactly, but it's definitely an issue and something I don't want to forget about.
@MatthewBlanchard MatthewBlanchard added bug Something isn't working urgent Urgent bug causing significant breakage. labels Jul 15, 2021
@MatthewBlanchard
Copy link
Contributor Author

MatthewBlanchard commented Jul 15, 2021 •
edited
Loading

Just figured this out. The distance from the point used in point picking is less than that used for adding a subdivision to a contour. This is something that just needs a bit of tweaking. It is specifically an issue with the grid because of how we're clamping the mouse coordinates to the grid coordinates.

@MatthewBlanchard
Copy link
Contributor Author

Fixed the part of this bug that caused the point_idx to change relative to the contour. The rest of this issue is more of an enhancement that I'll get to.

@MatthewBlanchard MatthewBlanchard removed the urgent Urgent bug causing significant breakage. label Jul 15, 2021
@MatthewBlanchard MatthewBlanchard changed the title Sometimes when trying to close a contour with the pen tool nothing happens and point_idx becomes contour.len() - 1. With grid enabled closing a contour can instead create a subdivision in some cases. Jul 15, 2021
@MatthewBlanchard MatthewBlanchard added the enhancement New feature or request label Jul 16, 2021
@ctrlcctrlv ctrlcctrlv removed the bug Something isn't working label Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MatthewBlanchard @ctrlcctrlv