Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't assume android phones use ARM or computers dont in cmakelists.txt #255

Open
tigercoding56 opened this issue Sep 12, 2021 · 1 comment

Comments

@tigercoding56
Copy link

tigercoding56 commented Sep 12, 2021

in the cmakelists txt there is a line if not android add option -msse3 this assumes that the user uses a compatible architecture which is generally a bad idea because you can run almost any os on ARM and via versa so you could replace it with
for example :
(its not in code tags because its a example )

if(CMAKE_PLATFORM_NAME == x86)
add_definition(-msse2)
elif(CMAKE_PLATFORM_NAME == x86_64)
add_definition(-msse2)
elif(CMAKE_PLATFORM_NAME == ARM)
add_definition(-mneon)
endif()

@JulioJerez
Copy link
Contributor

JulioJerez commented Sep 12, 2021 via email

@tigercoding56 tigercoding56 reopened this Sep 13, 2021
@tigercoding56 tigercoding56 changed the title better Cmakelists structuring don't assume android phones use ARM or computers dont in cmakelists.txt Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants