-
Notifications
You must be signed in to change notification settings - Fork 527
Conversation
I also tuned a padding and a margin in the main list. |
Good find! |
I am not sure what the fix is needed for and I didn't wanted to take risks for the upcoming stable version. XPrivacy uses a grid of a multiple of 3 or 6 dip. |
The margin fix only affects small and medium screens (you can see on the right of the list). Medium screens (padding and margin fixes) Large screens (padding fix) It's up to you! The padding fix is not mandatory, but the margin fix is necessary for non-large screens. |
I will look later into the padding and margin fixes. |
I forgot to fix the right margin of details view's list for small and medium screens. |
Can you please post screenshots of before and after the fix? |
@@ -5,6 +5,6 @@ | |||
screen margins) for sw720dp devices (e.g. 10" tablets) in landscape here. | |||
--> | |||
<dimen name="activity_horizontal_margin">128dp</dimen> | |||
<dimen name="activity_horizontal_margin_list">106dp</dimen> | |||
<dimen name="activity_horizontal_margin_list">112dp</dimen> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
106 dip is Android default, why needs this to be changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reduction of the list's right padding affects all screen sizes, but graphical render for large screens was already good before the fix. Thus we need to counter-balance the right padding reduction for large screens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like to keep the Android default.
This can never be a big deal om large screens.
The other margin fixes are applied now (unless I missed something) and it looks indeed nicer and makes a little bit more room for the application / restriction names.
Thanks for bringing this to my attention!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot test this, so I trust it is okay. |
Thanks! |
I should thank you ... |
This improves performances and allow us to get rid of the
NestedWeights
warning.The main list now scrolls slightly faster.