Parallel never calls apply

[ExpandingMan]

The Parallel layer never calls Lux.apply, but only calls its own method Lux.applyparallel. The problem with this is that if you try to overload methods of apply to implement your own input types as described here, Parallel will just completely ignore it.

I would suggest keeping applyparallel as is but first adding an extra indirection via apply to the call to Parallel.

[avik-pal]

it calls it here:

Lux.jl/src/layers/containers.jl

Line 183 in 8792097

[:(($(y_symbols[i]), $(st_symbols[i])) = @inline apply(

[ExpandingMan]

Right, but it's only calling it for the child layers not for Parallel itself, right?

[avik-pal]

The apply calls are redirected from LuxCore. apply(m, x, ps, st) -> m(x, ps, st) -> applyparallel(m, x, ps, st)

[ExpandingMan]

If apply calls m, shouldn't one overload m directly then instead of apply? The main issue I mean to raise here is that if one follows the instructions in the docs for creating custom input types, it passes the input through Parallel into its arguments without first executing the overloaded code on Parallel, which leads to unexpected results.

[avik-pal]

overloading m will lead to method ambiguities in most cases. Can you give a MWE for this case?