Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitcoin core rpc really only requires a single tx_hex: String as a generic. #8

Open
BitcoinZavior opened this issue Oct 2, 2023 · 3 comments
Open

bitcoin core rpc really only requires a single tx_hex: String as a generic. #8

BitcoinZavior opened this issue Oct 2, 2023 · 3 comments
Assignees
@BitcoinZavior

Comments

@BitcoinZavior
Copy link
Contributor

Bitcoin core rpc expects a Vec, but I think this function really only requires a single tx_hex: String as a generic.

Originally posted by @DanGould in #2 (comment)
@BitcoinZavior BitcoinZavior self-assigned this Oct 2, 2023
@BitcoinZavior
Copy link
Contributor Author

@DanGould This has been addressed here: 0b0cc4f

@DanGould
Copy link
Contributor

DanGould commented Oct 3, 2023 •
edited
Loading

this is closed then? I see you've also opted to pass bytes rather than a hex string

@BitcoinZavior
Copy link
Contributor Author

This has been addressed, this can be closed when the PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BitcoinZavior BitcoinZavior

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DanGould @BitcoinZavior